99 lines
5.9 KiB
Python
99 lines
5.9 KiB
Python
"""Synthetic checks for the global self-review rule and its manual entry points."""
|
|
|
|
from unittest import TestCase, mock
|
|
|
|
import test_knowledge as fixtures
|
|
from archive_store import ArchiveStore
|
|
from knowledge_access import KnowledgeAccessDenied
|
|
from knowledge_assignments import KnowledgeAssignments
|
|
|
|
|
|
class SelfReviewPolicyApiTest(TestCase):
|
|
tearDown = fixtures.KnowledgeApiTest.tearDown
|
|
payload = fixtures.KnowledgeTest.payload
|
|
start_job = fixtures.KnowledgeTest.start_job
|
|
process = fixtures.KnowledgeTest.process
|
|
first = fixtures.KnowledgeTest.first
|
|
|
|
def setUp(self):
|
|
fixtures.KnowledgeApiTest.setUp(self)
|
|
self.actor = self.db.authenticate('admin', 'ChangedAdmin@2026')['id']
|
|
self.store = self.client.app.state.knowledge_store
|
|
self.archive = ArchiveStore(self.db)
|
|
|
|
def test_policy_toggle_requires_permission_and_strict_boolean(self):
|
|
url = '/api/v2/knowledge/review-policy'
|
|
self.assertEqual(self.client.get(url, headers=self.headers).json(), {'allow_self_review': True})
|
|
self.assertEqual(self.client.put(url, headers=self.headers, json={'allow_self_review': 'false'}).status_code, 422)
|
|
self.db.create_user('policy-reader', 'InitialReader123', 'viewer', self.actor, '')
|
|
reader = self.db.authenticate('policy-reader', 'InitialReader123')['id']
|
|
self.db.change_password(reader, 'InitialReader123', 'ChangedReader@2026', '')
|
|
with self.db.connect() as db:
|
|
db.execute("INSERT OR IGNORE INTO role_permissions VALUES ('viewer','knowledge:read')")
|
|
login = self.client.post('/api/v2/auth/login', json={'username': 'policy-reader', 'password': 'ChangedReader@2026'})
|
|
headers = {'Authorization': 'Bearer ' + login.json()['access_token']}
|
|
self.assertEqual(self.client.put(url, headers=headers, json={'allow_self_review': False}).status_code, 403)
|
|
response = self.client.put(url, headers=self.headers, json={'allow_self_review': False})
|
|
self.assertEqual(response.status_code, 200, response.text)
|
|
self.assertEqual(self.client.get(url, headers=headers).json(), {'allow_self_review': False})
|
|
with self.db.connect() as db:
|
|
self.assertEqual(db.execute("SELECT COUNT(*) FROM audit_log WHERE action='knowledge.review.policy'").fetchone()[0], 1)
|
|
|
|
def test_assigned_owner_can_edit_but_cannot_review_when_disabled(self):
|
|
self.process()
|
|
item = self.first()
|
|
assignments = KnowledgeAssignments(self.store)
|
|
assignments.assign('*', [{'id': item['id'], 'revision': item['revision']}], self.actor, self.actor, '')
|
|
assignment_id = assignments.detail(self.actor, item['id'])['review_assignment']['id']
|
|
fields = {key: item[key] for key in ('revision', 'title', 'question', 'answer', 'category', 'kind', 'valid_until')}
|
|
fields['conditions'] = '仅适用于合成测试'
|
|
fields['assignment_id'] = assignment_id
|
|
route = '/api/v2/knowledge/my-reviews/' + item['id']
|
|
self.client.put('/api/v2/knowledge/review-policy', headers=self.headers, json={'allow_self_review': False})
|
|
with mock.patch('knowledge_review_policy.own_account_tenants', return_value=frozenset({'default'})):
|
|
saved = self.client.put(route, headers=self.headers, json=fields)
|
|
self.assertEqual(saved.status_code, 200, saved.text)
|
|
self.assertTrue(saved.json()['self_review_blocked'])
|
|
self.assertTrue(self.client.get(route, headers=self.headers).json()['self_review_blocked'])
|
|
self.assertTrue(self.client.get('/api/v2/knowledge/my-reviews', headers=self.headers).json()['items'][0]['self_review_blocked'])
|
|
for action in ('approve', 'reject', 'approve_publish'):
|
|
response = self.client.post(route + '/' + action, headers=self.headers,
|
|
json={'assignment_id': assignment_id, 'revision': saved.json()['revision'], 'confirmed': True})
|
|
self.assertEqual(response.status_code, 403, response.text)
|
|
self.assertEqual(self.store.detail('default', item['id'])['status'], 'draft')
|
|
|
|
|
|
class SelfReviewAfterIndexTest(TestCase):
|
|
fixture = fixtures.KnowledgeTest
|
|
setUp = fixture.setUp
|
|
tearDown = fixture.tearDown
|
|
payload = fixture.payload
|
|
start_job = fixture.start_job
|
|
process = fixture.process
|
|
first = fixture.first
|
|
def test_switch_disabled_during_indexing_fences_publication_commit(self):
|
|
self.process()
|
|
item = self.first()
|
|
assignments = KnowledgeAssignments(self.store)
|
|
assignments.assign('*', [{'id': item['id'], 'revision': item['revision']}], self.actor, self.actor, '')
|
|
assigned = assignments.detail(self.actor, item['id'])
|
|
assignment_id = assigned['review_assignment']['id']
|
|
assigned['conditions'] = '仅适用于合成测试'
|
|
saved = assignments.save(self.actor, item['id'], assigned, assignment_id, '')
|
|
|
|
def index_and_disable(_draft):
|
|
with self.db.connect() as db:
|
|
db.execute('INSERT INTO knowledge_review_policy(id,allow_self_review) VALUES(1,0)')
|
|
return 'synthetic-profile'
|
|
|
|
with mock.patch('knowledge_review_policy.own_account_tenants', return_value=frozenset({'default'})), \
|
|
mock.patch('knowledge_retriever.VectorIndex') as index:
|
|
index.return_value.configured = True
|
|
index.return_value.publish.side_effect = index_and_disable
|
|
with self.assertRaisesRegex(KnowledgeAccessDenied, '自己的知识须由他人审核'):
|
|
assignments.transition(self.actor, item['id'], saved['revision'], assignment_id, 'approve_publish', '', True)
|
|
self.assertEqual(self.store.detail('default', item['id'])['status'], 'draft')
|
|
with self.db.connect() as db:
|
|
self.assertEqual(db.execute("SELECT COUNT(*) FROM knowledge_revision WHERE item_id=? "
|
|
"AND action IN ('approve','publish')", (item['id'],)).fetchone()[0], 0)
|