fix(admin): restore review workspace and add user account editing
This commit is contained in:
@@ -979,6 +979,19 @@ class ButtonPermissionTest(_Base):
|
||||
self.assertIsNotNone(self.db.authenticate("password-target", STRONG + "x"))
|
||||
self.assertIsNone(self.db.authenticate("password-target", STRONG + "new"))
|
||||
|
||||
def test_status_only_user_cannot_rename_but_can_save_unchanged_name(self):
|
||||
self.make_user("rename-target", "viewer")
|
||||
user = self.db.authenticate("rename-target", STRONG + "x")
|
||||
status_only = self.role_user("rename-status", ["user:read", "user:status"])
|
||||
url = f"/api/v2/users/{user['id']}"
|
||||
forbidden = self.client.put(url, headers=status_only,
|
||||
json={"username": "other-name", "role": "viewer", "active": False})
|
||||
self.assertEqual(forbidden.status_code, 403)
|
||||
self.assertIn("user:write", forbidden.json()["detail"])
|
||||
allowed = self.client.put(url, headers=status_only,
|
||||
json={"username": "rename-target", "role": "viewer", "active": False})
|
||||
self.assertEqual(allowed.status_code, 200, allowed.text)
|
||||
|
||||
def test_role_and_permission_menu_buttons(self):
|
||||
writer = self.role_user("role-writer", ["role:read", "role:write"])
|
||||
# role:write 只管修改已有角色;新建、删除是另外两个按钮
|
||||
@@ -997,6 +1010,39 @@ class ButtonPermissionTest(_Base):
|
||||
|
||||
|
||||
class UserApiTest(_Base):
|
||||
def test_edit_local_username_and_reset_password_preserves_identity(self):
|
||||
old_session = self.make_user("editable-user", "viewer")
|
||||
user = self.db.authenticate("editable-user", STRONG + "x")
|
||||
response = self.client.put(f"/api/v2/users/{user['id']}", headers=self.login(),
|
||||
json={"username": "renamed-user", "role": "operator", "active": True, "password": STRONG + "new"})
|
||||
self.assertEqual(response.status_code, 200, response.text)
|
||||
updated = next(u for u in response.json()["users"] if u["id"] == user["id"])
|
||||
self.assertEqual((updated["username"], updated["role"]), ("renamed-user", "operator"))
|
||||
self.assertTrue(updated["must_change_password"])
|
||||
self.assertIsNone(self.db.authenticate("editable-user", STRONG + "x"))
|
||||
self.assertEqual(self.db.authenticate("renamed-user", STRONG + "new")["id"], user["id"])
|
||||
self.assertEqual(self.client.get("/api/v2/me", headers=old_session).status_code, 401)
|
||||
|
||||
def test_invalid_or_duplicate_username_does_not_change_other_fields(self):
|
||||
self.make_user("keep-name", "viewer")
|
||||
user = self.db.authenticate("keep-name", STRONG + "x")
|
||||
admin = self.login()
|
||||
for username in ("", " ", "admin", "bad\nname", "x" * 101):
|
||||
response = self.client.put(f"/api/v2/users/{user['id']}", headers=admin,
|
||||
json={"username": username, "role": "operator", "active": False})
|
||||
self.assertEqual(response.status_code, 400, response.text)
|
||||
unchanged = self.db.authenticate("keep-name", STRONG + "x")
|
||||
self.assertEqual(unchanged["role"], "viewer")
|
||||
|
||||
def test_group_and_builtin_account_names_are_protected(self):
|
||||
from test_group_sso import IDENTITY
|
||||
group = self.db.group_sso_user(IDENTITY)
|
||||
admin = self.login()
|
||||
for user_id, role in ((1, "admin"), (group["id"], "zyt_basic")):
|
||||
response = self.client.put(f"/api/v2/users/{user_id}", headers=admin,
|
||||
json={"username": "other-name", "role": role, "active": True})
|
||||
self.assertEqual(response.status_code, 400, response.text)
|
||||
|
||||
def test_the_listing_never_leaks_password_material(self):
|
||||
headers = self.login()
|
||||
body = self.client.get("/api/v2/users", headers=headers).text
|
||||
|
||||
Reference in New Issue
Block a user