geng

app/tests/test_prescription_security_ui.py

@@ -16,6 +16,7 @@ from doctor_workstation.ui.dialogs import diagnosis as diagnosis_module
 from doctor_workstation.ui.dialogs import prescription as dialog_module
 from doctor_workstation.ui.dialogs.diagnosis import DiagnosisDialog
 from doctor_workstation.ui.dialogs.prescription import (
+    DiagnosisDetailDialog,
     PrescriptionEditorDialog,
     PrescriptionOrderDialog,
     PrescriptionTemplateDialog,
@@ -287,6 +288,125 @@ def test_paid_order_response_is_bound_to_active_diagnosis_and_blocks_save(
     application.processEvents()
 
 
+def test_diagnosis_order_detail_lookup_is_queued_before_repository_call(
+    application: QApplication,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    queued: list[tuple[Any, dict[str, Any]]] = []
+    requested: list[int] = []
+    shown: list[tuple[int, str]] = []
+
+    class Repository:
+        def get_prescription_order(self, order_id: int) -> dict[str, Any]:
+            requested.append(order_id)
+            return {"id": order_id, "order_no": f"DETAIL-{order_id}"}
+
+    def queue_async(function: Any, **options: Any) -> object:
+        queued.append((function, options))
+        return object()
+
+    def present_order_detail(
+        _host: Any,
+        order: dict[str, Any],
+        *,
+        order_id: int,
+        permissions: Any,
+        exec_: bool,
+    ) -> None:
+        del permissions, exec_
+        shown.append((order_id, order["order_no"]))
+
+    monkeypatch.setattr(dialog_module, "run_async", queue_async)
+    monkeypatch.setattr(diagnosis_module, "present_order_detail", present_order_detail)
+    dialog = DiagnosisDetailDialog(
+        {"orders": [{"id": 17, "order_no": "ROW-17"}]},
+        repository=Repository(),
+    )
+    table = dialog._order_detail_table
+    button = dialog._order_detail_button
+    assert table is not None
+    assert button is not None
+    table.setCurrentCell(0, 0)
+
+    button.click()
+
+    assert len(queued) == 1
+    assert requested == []
+    assert shown == []
+    assert not table.isEnabled()
+    assert not button.isEnabled()
+
+    function, options = queued[0]
+    options["on_success"](function())
+    options["on_finished"]()
+    assert requested == [17]
+    assert shown == [(17, "DETAIL-17")]
+    assert table.isEnabled()
+    assert button.isEnabled()
+    dialog.close()
+    application.processEvents()
+
+
+def test_diagnosis_order_detail_ignores_stale_result_and_keeps_row_fallback(
+    application: QApplication,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    queued: list[dict[str, Any]] = []
+    shown: list[tuple[int, str]] = []
+
+    def queue_async(_function: Any, **options: Any) -> object:
+        queued.append(options)
+        return object()
+
+    def present_order_detail(
+        _host: Any,
+        order: dict[str, Any],
+        *,
+        order_id: int,
+        permissions: Any,
+        exec_: bool,
+    ) -> None:
+        del permissions, exec_
+        shown.append((order_id, order["order_no"]))
+
+    repository = SimpleNamespace(get_prescription_order=lambda order_id: {"id": order_id})
+    monkeypatch.setattr(dialog_module, "run_async", queue_async)
+    monkeypatch.setattr(diagnosis_module, "present_order_detail", present_order_detail)
+    dialog = DiagnosisDetailDialog(
+        {
+            "orders": [
+                {"id": 21, "order_no": "ROW-21"},
+                {"id": 22, "order_no": "ROW-22"},
+            ]
+        },
+        repository=repository,
+    )
+    table = dialog._order_detail_table
+    button = dialog._order_detail_button
+    assert table is not None
+    assert button is not None
+
+    table.setCurrentCell(0, 0)
+    dialog._open_selected_order()
+    table.setCurrentCell(1, 0)
+    dialog._open_selected_order()
+    assert len(queued) == 2
+
+    queued[0]["on_success"]({"id": 21, "order_no": "STALE-21"})
+    queued[0]["on_finished"]()
+    assert shown == []
+    assert not table.isEnabled()
+    assert not button.isEnabled()
+
+    queued[1]["on_error"](RuntimeError("detail unavailable"))
+    queued[1]["on_finished"]()
+    assert shown == [(22, "ROW-22")]
+    assert table.isEnabled()
+    assert button.isEnabled()
+    dialog.close()
+    application.processEvents()
+
+
 def _finish_queued(callback: dict[str, Any], result: Any) -> None:
     callback["on_success"](result)
     if callback.get("on_finished"):