feat(followup-audio): inline review with serialized draft autosave
This commit is contained in:
@@ -369,7 +369,7 @@ test('changed real-row target and changed record date require saving a fresh sna
|
||||
f.panel.reviewItems.value[0].target_id = 7
|
||||
await f.panel.applySelected()
|
||||
assert.equal(f.calls.filter(call => call[0] === 'apply').length, 0)
|
||||
assert.match(f.panel.applyIssue.value, /先保存审核草稿/)
|
||||
assert.match(f.panel.applyIssue.value, /审核草稿尚未保存完成/)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
@@ -387,6 +387,8 @@ test('read-only identity fields cannot be selected or applied, including mixed e
|
||||
await settle(); await f.panel.openTask(1); await f.panel.applySelected()
|
||||
assert.equal(f.calls.filter(call => call[0] === 'apply').length, 0)
|
||||
delete f.panel.reviewItems.value[0].values.phone
|
||||
assert.match(f.panel.applyIssue.value, /尚未保存完成/)
|
||||
await f.panel.saveDraft()
|
||||
assert.equal(f.panel.applyIssue.value, '')
|
||||
f.dispose()
|
||||
const source = fs.readFileSync(path.join(componentDir, 'FollowupAudioReview.vue'), 'utf8')
|
||||
@@ -576,7 +578,7 @@ test('server refresh during a modal edit keeps local content, uses fresh evidenc
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('panel leave guard includes unsaved modal edits; recording original is collapsed until playback', async () => {
|
||||
test('panel leave guard includes unsaved editor edits; playback stays separate from collapsed transcript', async () => {
|
||||
const f = setupPanel({}, {}, { confirm: async () => { throw new Error('cancel') } })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
const r = setupReview({ items: f.panel.reviewItems.value })
|
||||
@@ -587,7 +589,7 @@ test('panel leave guard includes unsaved modal edits; recording original is coll
|
||||
r.review.cancelReview(); assert.equal(f.panel.dirty.value, false)
|
||||
assert.deepEqual(f.panel.detailSections.value, [])
|
||||
await f.panel.loadAudio(5000)
|
||||
assert.deepEqual(f.panel.detailSections.value, ['original'])
|
||||
assert.deepEqual(f.panel.detailSections.value, [], 'same-page player does not expand the transcript')
|
||||
await f.panel.backToList()
|
||||
assert.deepEqual(f.panel.detailSections.value, [])
|
||||
r.dispose(); f.dispose()
|
||||
@@ -1151,7 +1153,7 @@ test('API forwards optional channel_roles only in draft and stereo apply uses se
|
||||
let current = stereoTask()
|
||||
const applied = []
|
||||
const f = setupPanel({ followupAudioDetail: async () => current, followupAudioSaveDraft: async payload => {
|
||||
current = { ...current, version: 2, channel_roles: payload.channel_roles, items: payload.items.map(row => ({ ...row, selected: false, needs_review: true })) }
|
||||
current = { ...current, version: payload.version + 1, channel_roles: payload.channel_roles || current.channel_roles, items: payload.channel_roles ? payload.items.map(row => ({ ...row, selected: false, needs_review: true })) : payload.items }
|
||||
return current
|
||||
}, followupAudioApply: async payload => { applied.push(payload); current = { ...current, status: 'applied', items: payload.items }; return { id: 1, status: 'applied', applied_items: [] } } })
|
||||
await settle(); await f.panel.openTask(1); f.panel.setChannelRoles('left_service'); await f.panel.saveDraft()
|
||||
@@ -1159,9 +1161,10 @@ test('API forwards optional channel_roles only in draft and stereo apply uses se
|
||||
const review = setupReview({ items: f.panel.reviewItems.value })
|
||||
review.review.openReview('blood-1'); review.review.confirmReview(true); review.review.saveReview(true)
|
||||
f.panel.reviewItems.value = review.props.items
|
||||
await f.panel.saveDraft()
|
||||
await f.panel.applySelected()
|
||||
assert.equal(applied.length, 1)
|
||||
assert.equal(applied[0].version, 2)
|
||||
assert.equal(applied[0].version, 3)
|
||||
assert.equal(Object.hasOwn(applied[0], 'channel_roles'), false, 'apply uses authoritative server-saved role mapping')
|
||||
assert.equal(f.panel.detail.value.status, 'applied')
|
||||
assert.deepEqual(f.events, [['applied', 10]])
|
||||
@@ -1553,3 +1556,240 @@ test('cancelled file selection keeps current file and roles; new upload starts u
|
||||
assert.equal(f.panel.uploadChannelRoles.value, 'unconfirmed')
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('autosave ignores hydration, debounces committed draft edits and never writes clinical records', async () => {
|
||||
const f = setupPanel({}, { capabilities: previewCaps() })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.tick(); await settle()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 0, 'server hydration does not save itself')
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7.1
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7.2
|
||||
f.panel.reviewItems.value[0].selected = false
|
||||
assert.equal(f.panel.saveState.value, 'pending')
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 0)
|
||||
f.tick(); await settle()
|
||||
const saves = f.calls.filter(x => x[0] === 'save')
|
||||
assert.equal(saves.length, 1)
|
||||
assert.equal(saves[0][1].items[0].values.fasting_blood_sugar, 7.2)
|
||||
assert.equal(saves[0][1].items[0].selected, false)
|
||||
assert.equal(f.panel.saveState.value, 'saved')
|
||||
assert.equal(f.panel.persistedRevision.value, 1)
|
||||
f.tick(); await settle()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 1, 'ACK hydration causes no write loop')
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0)
|
||||
assert.deepEqual(f.events, [])
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('autosave serializes delayed commits, merges newer local edits and advances request versions', async () => {
|
||||
const requests = [], pending = []
|
||||
const f = setupPanel({ followupAudioSaveDraft: payload => { requests.push(payload); const next = deferred(); pending.push(next); return next.promise } })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7
|
||||
f.tick(); await settle()
|
||||
assert.equal(requests.length, 1)
|
||||
assert.equal(f.panel.saveState.value, 'saving')
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
f.panel.reviewItems.value[0].selected = false
|
||||
f.tick(); await settle()
|
||||
assert.equal(requests.length, 1, 'only one request in flight')
|
||||
pending[0].resolve(task(1, { version: 2, items: requests[0].items })); await settle()
|
||||
assert.equal(f.panel.reviewItems.value[0].values.fasting_blood_sugar, 8)
|
||||
assert.equal(f.panel.reviewItems.value[0].selected, false)
|
||||
assert.equal(f.panel.saveState.value, 'pending')
|
||||
assert.equal(f.panel.persistedRevision.value, 0, 'outdated ACK does not claim latest edits saved')
|
||||
f.tick(); await settle()
|
||||
assert.equal(requests.length, 2)
|
||||
assert.equal(requests[1].version, 2)
|
||||
assert.equal(requests[1].items[0].values.fasting_blood_sugar, 8)
|
||||
pending[1].resolve(task(1, { version: 3, items: requests[1].items })); await settle()
|
||||
assert.equal(f.panel.detail.value.version, 3)
|
||||
assert.equal(f.panel.saveState.value, 'saved')
|
||||
assert.equal(f.panel.committedDirty.value, false)
|
||||
assert.equal(f.panel.persistedRevision.value, 1)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('same-data save ACK retains item references and never disables or saves a dirty next editor', async () => {
|
||||
const pending = deferred(), sent = []
|
||||
const f = setupPanel({ followupAudioSaveDraft: payload => { sent.push(payload); return pending.promise } })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7
|
||||
f.tick(); await settle()
|
||||
const committed = f.panel.reviewItems.value
|
||||
f.panel.reviewRef.value = { hasUnsavedChanges: () => true }
|
||||
pending.resolve(task(1, { version: 2, items: sent[0].items })); await settle()
|
||||
assert.equal(f.panel.reviewItems.value, committed, 'ACK must not trigger Review items replacement')
|
||||
assert.equal(f.panel.dirty.value, true, 'uncommitted next editor remains dirty')
|
||||
assert.equal(f.panel.committedDirty.value, false)
|
||||
assert.equal(sent.length, 1)
|
||||
await f.panel.applySelected()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0)
|
||||
f.dispose()
|
||||
const source = fs.readFileSync(path.join(componentDir, 'FollowupAudioPanel.vue'), 'utf8')
|
||||
assert.match(source, /:disabled="!canEditReview \|\| uploading \|\| \(mutation !== '' && mutation !== 'save'\)"/)
|
||||
})
|
||||
|
||||
test('autosave writes committed items even while a different editor has uncommitted changes', async () => {
|
||||
const f = setupPanel(); await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].selected = false
|
||||
f.panel.reviewRef.value = { hasUnsavedChanges: () => true }
|
||||
f.tick(); await settle()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 1)
|
||||
assert.equal(f.panel.dirty.value, true)
|
||||
assert.equal(f.panel.saveState.value, 'saved')
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('autosave failure stops retries and Apply until an explicit retry succeeds', async () => {
|
||||
let failing = true
|
||||
const f = setupPanel({ followupAudioSaveDraft: async payload => {
|
||||
f.calls.push(['save', payload])
|
||||
if (failing) throw new Error('网络中断')
|
||||
return task(1, { version: payload.version + 1, items: payload.items })
|
||||
} })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7
|
||||
f.tick(); await settle()
|
||||
assert.equal(f.panel.saveState.value, 'error')
|
||||
assert.match(f.panel.errorMessage.value, /自动保存已暂停.*重试保存/)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
f.tick(); await settle(); f.tick(); await settle()
|
||||
await f.panel.applySelected()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 1)
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0)
|
||||
assert.equal(f.panel.reviewItems.value[0].values.fasting_blood_sugar, 8)
|
||||
failing = false; await f.panel.saveDraft()
|
||||
assert.equal(f.panel.saveState.value, 'saved')
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 2)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('autosave conflict refreshes immutable metadata, keeps local values and pauses instead of looping', async () => {
|
||||
let stale = false
|
||||
const f = setupPanel({
|
||||
followupAudioDetail: async () => task(1, { version: stale ? 2 : 1, items: [item({ expected_hash: stale ? 'new' : 'old' })] }),
|
||||
followupAudioSaveDraft: async payload => { f.calls.push(['save', payload]); stale = true; throw new apiModule.FollowupAudioError('版本已变化', 'FOLLOWUP_AUDIO_STALE_REVIEW') }
|
||||
})
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
f.tick(); await settle()
|
||||
assert.equal(f.panel.saveState.value, 'conflict')
|
||||
assert.equal(f.panel.reviewItems.value[0].expected_hash, 'new')
|
||||
assert.equal(f.panel.reviewItems.value[0].values.fasting_blood_sugar, 8)
|
||||
assert.equal(f.panel.reviewItems.value[0].selected, false)
|
||||
assert.equal(f.panel.reviewItems.value[0].needs_review, true)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 9
|
||||
f.tick(); await settle(); f.tick(); await settle()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 1)
|
||||
assert.equal(f.panel.saveState.value, 'conflict')
|
||||
assert.match(f.panel.errorMessage.value, /重新核对.*重试保存/)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('autosave Apply stays explicit and blocked while pending, saving or edited during confirmation', async () => {
|
||||
const pending = deferred(), confirmation = deferred(), sent = []
|
||||
const f = setupPanel({ followupAudioSaveDraft: payload => { sent.push(payload); return pending.promise } }, {}, { confirm: () => confirmation.promise })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7
|
||||
await f.panel.applySelected()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0)
|
||||
f.tick(); await settle(); await f.panel.applySelected()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0)
|
||||
pending.resolve(task(1, { version: 2, items: sent[0].items })); await settle()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0, 'draft ACK never auto-applies')
|
||||
const applying = f.panel.applySelected(); await settle()
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
confirmation.resolve(true); await applying
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0, 'confirmation does not authorize edits made after it opened')
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('pending autosave and late ACK cannot cross patients or tasks', async () => {
|
||||
const pending = deferred(), sent = []
|
||||
const f = setupPanel({ followupAudioSaveDraft: payload => { sent.push(payload); return pending.promise } })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 7
|
||||
f.props.diagnosisId = 20; await settle(); f.tick(); await settle()
|
||||
assert.equal(sent.length, 0, 'debounced old-patient draft is cancelled')
|
||||
await f.panel.openTask(2)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
f.tick(); await settle()
|
||||
assert.equal(sent.length, 1)
|
||||
assert.equal(sent[0].id, 2)
|
||||
f.props.diagnosisId = 30; await settle(); await f.panel.openTask(3)
|
||||
pending.resolve(task(2, { version: 2, items: sent[0].items })); await settle()
|
||||
assert.equal(f.panel.selectedId.value, 3)
|
||||
assert.equal(f.panel.reviewItems.value[0].values.fasting_blood_sugar, 6.5)
|
||||
assert.equal(f.panel.persistedRevision.value, 0)
|
||||
assert.equal(f.panel.saveState.value, 'idle')
|
||||
assert.deepEqual(f.events, [])
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('role autosave preserves a newer mapping and serializes another save without selecting suggestions', async () => {
|
||||
const requests = [], pending = []
|
||||
const f = setupPanel({ followupAudioDetail: async () => stereoTask(), followupAudioSaveDraft: payload => { requests.push(payload); const request = deferred(); pending.push(request); return request.promise } })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.setChannelRoles('left_service'); f.tick(); await settle()
|
||||
f.panel.setChannelRoles('right_service')
|
||||
assert.equal(f.panel.channelRoles.value, 'right_service', 'role edits stay available during save')
|
||||
pending[0].resolve(stereoTask({ version: 2, channel_roles: 'left_service', items: [item({ selected: false, needs_review: true })] })); await settle()
|
||||
assert.equal(f.panel.channelRoles.value, 'right_service')
|
||||
assert.equal(f.panel.savedChannelRoles.value, 'left_service')
|
||||
assert.equal(f.panel.reviewItems.value[0].selected, false)
|
||||
f.tick(); await settle()
|
||||
assert.equal(requests.length, 2)
|
||||
assert.equal(requests[1].version, 2)
|
||||
assert.equal(requests[1].channel_roles, 'right_service')
|
||||
pending[1].resolve(stereoTask({ version: 3, channel_roles: 'right_service', items: requests[1].items })); await settle()
|
||||
assert.equal(f.panel.saveState.value, 'saved')
|
||||
assert.equal(f.panel.roleDirty.value, false)
|
||||
assert.equal(f.calls.filter(x => x[0] === 'apply').length, 0)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('panel has one same-page slotted player and collapses only transcript and advanced settings', () => {
|
||||
const source = fs.readFileSync(path.join(componentDir, 'FollowupAudioPanel.vue'), 'utf8')
|
||||
assert.equal((source.match(/<audio\s/g) || []).length, 1)
|
||||
assert.match(source, /<template #player>[\s\S]*?<audio[\s\S]*?<\/template>\s*<\/FollowupAudioReview>/)
|
||||
assert.doesNotMatch(source.slice(source.indexOf('<el-collapse v-model="detailSections"'), source.indexOf('<div v-if="detail.status === \'review\'" class="review-actions"')), /<audio\s/)
|
||||
assert.match(source, /el-collapse-item title="高级设置 · 分析模型"/)
|
||||
assert.match(source, /!editingRoles && !roleDirty/)
|
||||
assert.match(source, /@click="editingRoles = true">修改/)
|
||||
})
|
||||
|
||||
test('late save merging never resurrects selections invalidated by the server snapshot', async () => {
|
||||
const pending = deferred(), sent = []
|
||||
const f = setupPanel({ followupAudioSaveDraft: payload => { sent.push(payload); return pending.promise } })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
f.panel.reviewItems.value[0].target_id = 9
|
||||
f.panel.reviewItems.value[0].selected = false
|
||||
f.tick(); await settle()
|
||||
f.panel.reviewItems.value[0].selected = true
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
pending.resolve(task(1, { version: 2, items: sent[0].items.map(row => ({ ...row, expected_hash: 'new-target', selected: false, needs_review: true })) })); await settle()
|
||||
assert.equal(f.panel.reviewItems.value[0].values.fasting_blood_sugar, 8)
|
||||
assert.equal(f.panel.reviewItems.value[0].expected_hash, 'new-target')
|
||||
assert.equal(f.panel.reviewItems.value[0].selected, false)
|
||||
assert.equal(f.panel.reviewItems.value[0].needs_review, true)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
test('detail fetch begun before an edit preserves that edit when the new snapshot arrives', async () => {
|
||||
const pending = deferred()
|
||||
let fetching = false
|
||||
const f = setupPanel({ followupAudioDetail: async () => fetching ? pending.promise : task() })
|
||||
await settle(); await f.panel.openTask(1)
|
||||
fetching = true
|
||||
const refreshing = f.panel.readDetail(1)
|
||||
f.panel.reviewItems.value[0].values.fasting_blood_sugar = 8
|
||||
pending.resolve(task(1, { version: 2, items: [item({ expected_hash: 'fresh' })] })); await refreshing
|
||||
assert.equal(f.panel.reviewItems.value[0].values.fasting_blood_sugar, 8)
|
||||
assert.equal(f.panel.reviewItems.value[0].expected_hash, 'fresh')
|
||||
assert.equal(f.panel.saveState.value, 'conflict')
|
||||
assert.equal(f.panel.reviewItems.value[0].selected, false)
|
||||
f.tick(); await settle()
|
||||
assert.equal(f.calls.filter(x => x[0] === 'save').length, 0)
|
||||
f.dispose()
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user